don't include series hash when no labels to exclude in projection hints#128
Merged
jesusvazquez merged 1 commit intoprometheus-community:mainfrom Dec 11, 2025
Conversation
Signed-off-by: yeya24 <benye@amazon.com>
3 tasks
MichaHoffmann
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, when no projection the projection hints will be projection include set to false and no projection labels. This should fetch all labels which is the same as no projection.
However, the implementation today will fetch all labels + hash column on the default case. This is totally unnecessary as series hash should be only fetched when we skip fetching certain labels due to projection. But the default case, we still fetch all label columns then there is no need to fetch the hash column.
This PR adds a check to only fetch hash when there is at least 1 projection label to exclude.